Add support for BERT-encoded RabbitMQ replies #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2017 13:52
E.g. for 10000 queues performing the sort using the default sorting order costs ~0.3 second on my machine. Now that rabbitmq/rabbitmq-management#369 is merged we can avoid this cost.
Since 3.6.9 (see rabbitmq/rabbitmq-management#367) RabbitMQ supports BERT encoding as a JSON alternative. Given that BERT encoding is implemented in C inside the Erlang VM, it's way more effective than pure-Erlang JSON encoding. So this greatly reduces monitoring overhead when we have a lot of objects in RabbitMQ.
|
Hi, I've merged it into the develop branch. Docker image was created (tag: develop). LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly done, just waiting for a couple of other PRs:
Since 3.6.9 (see rabbitmq/rabbitmq-management#367) RabbitMQ
supports BERT encoding as a JSON alternative. Given that BERT encoding
is implemented in C inside the Erlang VM, it's way more effective than
pure-Erlang JSON encoding. So this greatly reduces monitoring overhead
when we have a lot of objects in RabbitMQ.